Add preflight check if video is supported by browser#38858
Merged
AlexAndBear merged 1 commit intomasterfrom Jun 17, 2021
Merged
Add preflight check if video is supported by browser#38858AlexAndBear merged 1 commit intomasterfrom
AlexAndBear merged 1 commit intomasterfrom
Conversation
phil-davis
reviewed
Jun 16, 2021
AlexAndBear
force-pushed
the
enterprise/issues/4632
branch
from
1c2769c to
dfd086f
Compare
Contributor
💥 Acceptance tests apiAuth-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests apiShareOperationsToShares2-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests apiShareManagementBasicToShares-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests apiShareCreateSpecialToShares1-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests apiCapabilities-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests webUISharingNotify-chrome-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests cliTrashbin-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests apiProxySmoke-8-8-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests cliMain-mariadb10.2-php7.4 failed. The build is cancelled... |
Contributor
💥 Acceptance tests cliExternalStorage-10.6.0-mariadb10.2-php7.4 failed. The build is cancelled... |
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
Jun 17, 2021
Contributor
|
Note: this has missed the branch point of
@micbar FYI |
Author
|
Rebased by @micbar so this lands in 10.8.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Show notification if video playback is not possible on public share
Before this PR no error notification was shown if a video can't be played due
to browser incompatibility, for example, mov files on chrome.
(https://stackoverflow.com/questions/28746645)
Now we will show a dedicated notification.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: