X Tutup
Skip to content

adapt to new html structure#38853

Merged
phil-davis merged 3 commits intomasterfrom
20210615-fix-login-screen-changes
Jun 15, 2021
Merged

adapt to new html structure#38853
phil-davis merged 3 commits intomasterfrom
20210615-fix-login-screen-changes

Conversation

@hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Jun 15, 2021 •
edited by phil-davis
Loading

Description

Related Issue

Possible fix for #38821 (comment)
Issue owncloud/password_policy#338

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor

phil-davis commented Jun 15, 2021

Looks good - test scenarios are passing in https://drone.owncloud.com/owncloud/password_policy/1812/24/11 webUIPasswordReset test suite. (They were failing without this fix)

@phil-davis
Copy link
Contributor

phil-davis commented Jun 15, 2021

You could add a link to this PR onto https://github.com/owncloud/core/blob/master/changelog/unreleased/38506

@phil-davis phil-davis mentioned this pull request Jun 15, 2021
Closed
@owncloud owncloud deleted a comment from update-docs bot Jun 15, 2021
@hurradieweltgehtunter
Copy link
Contributor Author

hurradieweltgehtunter commented Jun 15, 2021

Let's wait for CI to complete?

@phil-davis
Copy link
Contributor

phil-davis commented Jun 15, 2021

Let's wait for CI to complete?

I am confident - the test CI in password_policy will finish and be green in 30 minutes. This core PR will take about an hour to finish its CI. Then we will know the meaning of "life, the universe and everything" and can merge this ;)

@hurradieweltgehtunter
Copy link
Contributor Author

hurradieweltgehtunter commented Jun 15, 2021

Going full-range philosophical here :D
Ok fine with me, up to you. You are a lot more familiar with CI

@phil-davis phil-davis mentioned this pull request Jun 15, 2021
Closed
@phil-davis
Copy link
Contributor

phil-davis commented Jun 15, 2021

Test PR owncloud/password_policy#339 has passed. This is "a good thing" and can be merged when CI is green.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit db0dca3 into master Jun 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the 20210615-fix-login-screen-changes branch June 15, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hurradieweltgehtunter @phil-davis
X Tutup