X Tutup
Skip to content

Prevent files:checksum:verify from crashing on exception#38785

Merged
JammingBen merged 3 commits intomasterfrom
verify-checksum-exceptions
May 27, 2021
Merged

Prevent files:checksum:verify from crashing on exception#38785
JammingBen merged 3 commits intomasterfrom
verify-checksum-exceptions

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented May 27, 2021

Description

The command now skips files with exceptions instead of crashing. A proper message will be displayed to the user who fires the command.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot May 27, 2021
AlexAndBear
AlexAndBear suggested changes May 27, 2021
View reviewed changes
karakayasemi
karakayasemi approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phil-davis phil-davis requested a review from AlexAndBear May 27, 2021 09:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JammingBen JammingBen merged commit 701c4a7 into master May 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the verify-checksum-exceptions branch May 27, 2021 09:56
This was referenced Jul 15, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

3 more reviewers

@IljaN IljaN IljaN approved these changes

@karakayasemi karakayasemi karakayasemi approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent occ files:checksum:verify -r from crashing on exception

4 participants

@JammingBen @IljaN @karakayasemi @AlexAndBear
X Tutup