X Tutup
Skip to content

Fix migration by loading the app without checking, after correct update#38773

Merged
phil-davis merged 2 commits intomasterfrom
fix_files_external_migration
May 27, 2021
Merged

Fix migration by loading the app without checking, after correct update#38773
phil-davis merged 2 commits intomasterfrom
fix_files_external_migration

Conversation

@jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented May 25, 2021 •
edited
Loading

Description

Some problems were detected with the upgrade from 10.5 to 10.8 (still in alpha state) related to the PR #38728 .
This new PR aims to fix the problems detected so far with the migration

Related Issue

Related to #38770
Linked with #38728

Motivation and Context

How Has This Been Tested?

  1. Install OC 10.5 and WND app 1.1.0
  2. Mount a GDrive and WND mount points (WND with username+password)
  3. Ensure you can access to the files inside the GDrive and WND
  4. Update OC to this branch (future 10.8) and update WND to 2.0.0
  5. Run the upgrade

Passwords have been migrated correctly and the user can access to the files inside both storages without problems

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this May 25, 2021
@jvillafanez jvillafanez mentioned this pull request May 25, 2021
Closed
@owncloud owncloud deleted a comment from update-docs bot May 25, 2021
@phil-davis
Copy link
Contributor

phil-davis commented May 25, 2021

This is an adjustment to a previous PR, so IMO changelog is not needed (or add this PR to the previous changelog)

@jvillafanez if this is ready, it could be reviewed and merged today. So we will get a CI run overnight of update-testing.

@jvillafanez
Copy link
Member Author

jvillafanez commented May 25, 2021 •
edited
Loading

Migration doesn't run properly... OC 10.5.0 -> 10.8.0 with WND username + password: the password is reset.
It would be interesting to know if this is the only case.

There is no crash so the upgrade goes through, but the fact that the password is reset will be annoying

@jvillafanez
Copy link
Member Author

jvillafanez commented May 25, 2021

Migration doesn't run properly...

Fixed with the last commit

@IljaN quick second check for the last commit? Otherwise this should be good to merge.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jvillafanez jvillafanez mentioned this pull request May 26, 2021
Merged
11 tasks
@IljaN
Copy link
Contributor

IljaN commented May 27, 2021

LGTM!

@phil-davis phil-davis merged commit 4e285cf into master May 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_files_external_migration branch May 27, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IljaN IljaN IljaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jvillafanez jvillafanez

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvillafanez @phil-davis @IljaN
X Tutup