fix: this allows to implement OPTIONS request handling in framework c…#38758
Merged
DeepDiver1975 merged 2 commits intomasterfrom Dec 1, 2021
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
@JammingBen fyi |
Contributor
|
@DeepDiver1975 Is this still needed? |
Member
Author
Don't needed anymore for my original case ..... but worth it as a general enhancement ... |
…ontrollers - if it is not a CORS preflight request. CORS requests will continue to be handled by core
JammingBen
force-pushed
the
fix/allow-options-requests-to-be-handled-by-controllers
branch
from
f4a08c2 to
3a3e580
Compare
Contributor
|
I rebased and added a changelog item. @DeepDiver1975 If you're fine with it we can merge. |
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
fix/allow-options-requests-to-be-handled-by-controllers
branch
Contributor
|
@DeepDiver1975 this is not in the |
Member
Author
no - thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ontrollers - if it is not a CORS preflight request. CORS requests will continue to be handled by core
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: