X Tutup
Skip to content

Add user profile picture boolean to capabilities#38722

Merged
phil-davis merged 1 commit intomasterfrom
add-profile-picture-capability
May 11, 2021
Merged

Add user profile picture boolean to capabilities#38722
phil-davis merged 1 commit intomasterfrom
add-profile-picture-capability

Conversation

@pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented May 10, 2021

Description

Adds another boolean to the capabilities

Related Issue

Motivation and Context

Needed for the new web frontend to know whether to fetch&render avatar profile pictures

Please review with care, I'm not a PHP dev!

@CLAassistant
Copy link

CLAassistant commented May 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@phil-davis
Copy link
Contributor

phil-davis commented May 10, 2021

We usually add new capabilites to https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiCapabilities/capabilities.feature test scenarios, similar to the way it is done at line 107.

Do you want me to add?

@pascalwengerter
Copy link
Contributor Author

pascalwengerter commented May 10, 2021

:x

We usually add new capabilites to https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiCapabilities/capabilities.feature test scenarios, similar to the way it is done at line 107.

Do you want me to add?

Great idea @phil-davis , please go ahead and do so (this will also restart the pipeline which should actually pass, timed out on the last run)

@phil-davis phil-davis force-pushed the add-profile-picture-capability branch from 0a44c69 to 8685cc3 Compare May 10, 2021 14:38
JammingBen
JammingBen suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise 👍 Just the PR-link in the changelog

@phil-davis phil-davis force-pushed the add-profile-picture-capability branch from 8685cc3 to 4418879 Compare May 11, 2021 11:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 69f1211 into master May 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-profile-picture-capability branch May 11, 2021 12:40
@kulmann kulmann mentioned this pull request May 12, 2021
Closed
This was referenced May 14, 2021
Merged
Merged
This was referenced Jun 18, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

+1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Communicate capability of showing user avatar images

4 participants

@pascalwengerter @CLAassistant @phil-davis @JammingBen
X Tutup