Closed
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This was referenced May 7, 2021
Closed
Contributor
Author
|
Federated acceptance tests are failing. sqlite+scality unit tests with messages like Needs investigating when someone wants to move forward with this. |
phil-davis
force-pushed
the
guzzle6-20210507
branch
from
1d7a204 to
3234cb3
Compare
Contributor
Author
|
This is here as a "record" of past code for updating Guzzle from v5 to v6. It should provide a good starting point if someone does this some day. |
Contributor
|
Superseded by #39368. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests/TestHelpers/Unittests again (they rely on having guzzle6 since the acceptance test code was updated to guzzle6)This is a recreation of PR #38266
Related Issue
Motivation and Context
Guzzle5 does not have official support on PHP 7.4 and probably never will have. Guzzle5 works on PHP 7.4
For future PHP versions (e.g. PHP 8.0) we might be forced to do this Guzzle update.
Note1: if we do this then apps that use Guzzle5 will also need updating to Guzzle6 and coordinated release of core and app versions etc.
Note2: guzzle is actually up to release https://github.com/guzzle/guzzle/releases/tag/7.2.0 - so if we bump guzzle we might want to bump it all the way to major version 7.
How Has This Been Tested?
CI
Types of changes
Checklist: