Prevent user to see directory content if share is a file drop#38691
Merged
AlexAndBear merged 1 commit intomasterfrom May 5, 2021
Merged
Prevent user to see directory content if share is a file drop#38691AlexAndBear merged 1 commit intomasterfrom
AlexAndBear merged 1 commit intomasterfrom
Conversation
AlexAndBear
force-pushed
the
issues/enterprise/4540
branch
from
874d47e to
0f8054c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mrow4a
approved these changes
May 5, 2021
C0rby
reviewed
May 10, 2021
| */ | ||
| function getChildInfo($dir, $view, $sharePermissions) { | ||
| // Prevent user to see directory content if share is a file drop | ||
| if ($sharePermissions === \OCP\Constants::PERMISSION_CREATE) { |
Contributor
There was a problem hiding this comment.
Personally I would have done
if ($sharePermissions & \OCP\Constants::PERMISSION_READ !== \OCP\Constants::PERMISSIONS_READ) {to check if the read permission bit is set.
This would be more flexible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requesting file drop share with the deprecated shareinfo API, exposed
information about the content of the file drop share.
We will now deliver empty content on the children entry.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: