Merged
Conversation
AlexAndBear
approved these changes
Apr 29, 2021
JammingBen
approved these changes
Apr 29, 2021
Contributor
|
Please rebase and add config.sample.php |
Contributor
|
@janackermann GitHub is reporting conflicts. This needs a rebase and resolve the conflicts. |
kulmann
force-pushed
the
configurable-web-rewrite
branch
from
26fd0d6 to
64f7a9f
Compare
Contributor
Author
|
Rebased / solved conflicts and added the PR url in the changelog. |
kulmann
force-pushed
the
configurable-web-rewrite
branch
from
64f7a9f to
81e1ee1
Compare
Contributor
Author
@micbar I adjusted the config.sample.php - could you have a look please? |
micbar
approved these changes
May 26, 2021
Contributor
|
approved. Trailing whitespace breaks CI |
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
@micbar CI is green again. Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hides the nav item when the oc10 web app is installed but disabled and skips the public & private link rewrite for the same reason. It also introduces a config option to enable public & private link rewrites, so that those are not rewritten by default but only if the admin decides to go for it.
Related Issue
Motivation and Context
Fix the app behaviour. Also, the feature set of ownCloud Web is not rich enough, yet, to enforce it being used on public links (misses e.g. office suites).
How Has This Been Tested?
Types of changes
Checklist: