X Tutup
Skip to content

when creating self group-reshare do not share to self#38581

Merged
phil-davis merged 2 commits intomasterfrom
bugfix/handle-self-group-reshare
Mar 30, 2021
Merged

when creating self group-reshare do not share to self#38581
phil-davis merged 2 commits intomasterfrom
bugfix/handle-self-group-reshare

Conversation

@mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Mar 24, 2021 •
edited
Loading

fixes https://github.com/owncloud/enterprise/issues/4382
related #38542

This PR solved the issue where user is resharing with group that himself belongs to, and where further resharing or increasing permissions is not possible due to self-share with reduced permission

  • manual tests
  • add unit and integration tests

@mrow4a mrow4a self-assigned this Mar 24, 2021
@update-docs
Copy link

update-docs bot commented Mar 24, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mrow4a mrow4a changed the title when creating self group-reshare do not create share to self when creating self group-reshare do not share to self Mar 24, 2021
@mrow4a mrow4a force-pushed the bugfix/handle-self-group-reshare branch 2 times, most recently from eadf8fa to e4122a1 Compare March 28, 2021 20:38
@mrow4a mrow4a marked this pull request as ready for review March 29, 2021 06:21
@mrow4a mrow4a mentioned this pull request Mar 29, 2021
Closed
2 tasks
phil-davis
phil-davis reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: probably the test scenarios could be just with the API. But I guess it is also useful that the test scenarios are driving the UI - that verifies that the UI is also correctly rendering the various situations.

@jvillafanez
Copy link
Member

jvillafanez commented Mar 29, 2021

Code looks good 👍 . Waiting for movement on the acceptance test's comments

@mrow4a mrow4a force-pushed the bugfix/handle-self-group-reshare branch from e4122a1 to 6d58407 Compare March 29, 2021 19:57
@phil-davis phil-davis self-requested a review March 30, 2021 00:44
phil-davis
phil-davis approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored some steps at the end of a scenario to be:
And user "Alice" should be able to create folder "/simple-empty-folder"

We have other "Then user Alice should be able to do something" steps. This one will also be useful to have (rather than writing and extra When/Then section at the end of a scenario.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 4d11dd4 into master Mar 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/handle-self-group-reshare branch March 30, 2021 02:21
@jesmrec jesmrec mentioned this pull request Jul 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

Assignees

@mrow4a mrow4a

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrow4a @jvillafanez @phil-davis
X Tutup