when resharing with group that user belongs permissions are most permissive already in mount provider#38542
Closed
when resharing with group that user belongs permissions are most permissive already in mount provider#38542
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mrow4a
force-pushed
the
bugfix/share-attribute-reshare-check
branch
9 times, most recently
from
c0728a7 to
9f0b447
Compare
…issive already in mount provider
mrow4a
force-pushed
the
bugfix/share-attribute-reshare-check
branch
from
9f0b447 to
6d856cd
Compare
2 tasks
Contributor
Author
|
In this PR I tried to fix the behaviour and adjust logic of permission handling/mounting. in #38581 I fixed root cause of the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/owncloud/enterprise/issues/4382
This PR solved the issue where user is resharing with group that himself belongs to, and we should not check for more permissive permissions/attributes in supershare as these are most permissive already .