X Tutup
Skip to content

Disable sharing on files_external if auth mechanism is not compatible#38483

Merged
AlexAndBear merged 1 commit intomasterfrom
enterprise/issues/4444
Mar 10, 2021
Merged

Disable sharing on files_external if auth mechanism is not compatible#38483
AlexAndBear merged 1 commit intomasterfrom
enterprise/issues/4444

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Mar 9, 2021 •
edited
Loading

Description

If we set up external storage and choose the auth mechanism 'Log-in credentials, save in session' sharing is not possible, to show this to the user, the checkbox will be disabled and a hint due a tooltip will be shown

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear requested a review from jvillafanez March 9, 2021 08:54
@AlexAndBear AlexAndBear self-assigned this Mar 9, 2021
@AlexAndBear AlexAndBear changed the title Disable sahring on files_external if auth mechanism is not compatible Disable sharing on files_external if auth mechanism is not compatible Mar 9, 2021
@AlexAndBear AlexAndBear force-pushed the enterprise/issues/4444 branch from b63a1ce to 86a950a Compare March 9, 2021 09:11
@owncloud owncloud deleted a comment from update-docs bot Mar 9, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review March 9, 2021 09:11
jvillafanez
jvillafanez reviewed Mar 9, 2021
View reviewed changes
@AlexAndBear AlexAndBear force-pushed the enterprise/issues/4444 branch from 86a950a to 9b492ec Compare March 9, 2021 10:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit eda0f15 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the enterprise/issues/4444 branch March 10, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@AlexAndBear AlexAndBear

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexAndBear @jvillafanez
X Tutup