X Tutup
Skip to content

Add value userType to sharees api #38440

Merged
AlexAndBear merged 1 commit intomasterfrom
issues/38422
Feb 25, 2021
Merged

Add value userType to sharees api #38440
AlexAndBear merged 1 commit intomasterfrom
issues/38422

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Feb 24, 2021 •
edited
Loading

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear linked an issue Feb 24, 2021 that may be closed by this pull request
[QA] guest user email is shown as normal user, when used for the second time #38422
Closed
@AlexAndBear AlexAndBear self-assigned this Feb 24, 2021
@owncloud owncloud deleted a comment from update-docs bot Feb 24, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review February 24, 2021 10:39
@AlexAndBear AlexAndBear changed the title Set user share type to guest if apply Add value isGuestUser to sharees api Feb 24, 2021
mrow4a
mrow4a reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@mrow4a mrow4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can api return „userType” instead? is this possible? this would make it more generic

@AlexAndBear
Copy link
Author

AlexAndBear commented Feb 24, 2021

can api return „userType” instead? is this possible? this would make it more generic

Of course, we can do this, are there more types than 'user' and 'guest'?

@mrow4a
Copy link
Contributor

mrow4a commented Feb 24, 2021

can api return „userType” instead? is this possible? this would make it more generic

Of course, we can do this, are there more types than 'user' and 'guest'?

needs to be investigated, best if returns some ID / CONST defined in core.

@AlexAndBear
Copy link
Author

AlexAndBear commented Feb 25, 2021

@mrow4a ok updated in that favor, might have quick look? if you give me green light, I will update the tests

@mrow4a mrow4a changed the title Add value isGuestUser to sharees api Add value userType to sharees api Feb 25, 2021
mrow4a
mrow4a requested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@mrow4a mrow4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally makes sense, one small detail to be fixed

@AlexAndBear AlexAndBear requested a review from mrow4a February 25, 2021 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear
Copy link
Author

AlexAndBear commented Feb 25, 2021

@mrow4a Tests passed, approve?

@AlexAndBear AlexAndBear merged commit 9db0a9c into master Feb 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/38422 branch February 25, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrow4a mrow4a mrow4a approved these changes

@jnweiger jnweiger Awaiting requested review from jnweiger

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@AlexAndBear AlexAndBear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QA] guest user email is shown as normal user, when used for the second time

2 participants

@AlexAndBear @mrow4a
X Tutup