Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
a61347c to
aa4fc47
Compare
aa4fc47 to
f36d380
Compare
f36d380 to
eb56b97
Compare
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Feb 8, 2021
Contributor
|
@C0rby Can you review from sec point of view? |
Contributor
|
@micbar, yes added to my Todo list. :) |
C0rby
approved these changes
Feb 9, 2021
Contributor
C0rby
left a comment
There was a problem hiding this comment.
Looks fine from a sec pov. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
with this patch it is possible to pass the correct DB platform via
config.phpmanually:or via a separate
db.config.phpfile:Related Issue
OC fails to install using MariaDB on Azure due to a known issue with MySQL version reporting https://docs.microsoft.com/en-us/azure/mariadb/concepts-limits#current-known-issues
Motivation and Context
Fixes installation and upgrade for MariaDB at Azure environment
Types of changes
Checklist: