X Tutup
Skip to content

Allow passing DB platform#38379

Merged
VicDeo merged 1 commit intomasterfrom
enhancment/e4370
Feb 9, 2021
Merged

Allow passing DB platform#38379
VicDeo merged 1 commit intomasterfrom
enhancment/e4370

Conversation

@VicDeo
Copy link
Member

@VicDeo VicDeo commented Feb 4, 2021

Description

with this patch it is possible to pass the correct DB platform via config.php manually:

'db.platform' => '\Doctrine\DBAL\Platforms\MariaDb1027Platform',

or via a separate db.config.php file:

<?php
$CONFIG = [
	'db.platform' => '\Doctrine\DBAL\Platforms\MariaDb1027Platform',
];

Related Issue

OC fails to install using MariaDB on Azure due to a known issue with MySQL version reporting https://docs.microsoft.com/en-us/azure/mariadb/concepts-limits#current-known-issues

MariaDB server instance displays the incorrect server version after connection is established. To get the correct server instance engine version, use the select version(); command.

Motivation and Context

Fixes installation and upgrade for MariaDB at Azure environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo self-assigned this Feb 4, 2021
@update-docs
Copy link

update-docs bot commented Feb 4, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@VicDeo VicDeo added this to the development milestone Feb 8, 2021
@VicDeo VicDeo changed the title [WIP] Allow passing DB platform Allow passing DB platform Feb 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VicDeo VicDeo requested review from jvillafanez and micbar February 8, 2021 14:33
@micbar micbar requested a review from C0rby February 8, 2021 15:22
@micbar
Copy link
Contributor

micbar commented Feb 8, 2021

@C0rby Can you review from sec point of view?

@C0rby
Copy link
Contributor

C0rby commented Feb 8, 2021

@micbar, yes added to my Todo list. :)

Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a sec pov. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup