X Tutup
Skip to content

Show error/success message while changing log level in admin settings#38340

Merged
AlexAndBear merged 1 commit intomasterfrom
issues/38220
Jan 26, 2021
Merged

Show error/success message while changing log level in admin settings#38340
AlexAndBear merged 1 commit intomasterfrom
issues/38220

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jan 25, 2021 •
edited
Loading

Description

This change will show a success/error message, while you change the log level in settings->administration->general

image

Related Issue

Motivation and Context

This will give the user instant feedback if the operation was successfull

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AlexAndBear AlexAndBear mentioned this pull request Jan 25, 2021
Closed
@AlexAndBear AlexAndBear self-assigned this Jan 25, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review January 25, 2021 13:42
@owncloud owncloud deleted a comment from update-docs bot Jan 25, 2021
JammingBen
JammingBen reviewed Jan 25, 2021
View reviewed changes
@phil-davis
Copy link
Contributor

phil-davis commented Jan 26, 2021

@janackermann the CLA assistant thinks that you have not signed! Please click the buttons to sign...

JammingBen
JammingBen reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works, nice! You accidentally committed changes to .htaccess and Makefile though. Otherwise it looks good to me.

@owncloud owncloud deleted a comment from phil-davis Jan 26, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit c1b1a16 into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/38220 branch January 26, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnweiger jnweiger Awaiting requested review from jnweiger

@phil-davis phil-davis Awaiting requested review from phil-davis

1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexAndBear AlexAndBear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[QA] admin GUI cannot change log level

4 participants

@AlexAndBear @CLAassistant @phil-davis @JammingBen
X Tutup