X Tutup
Skip to content

Prevent setlocale()-calls from overwriting themselves#38315

Merged
phil-davis merged 2 commits intomasterfrom
issues/38303
Jan 19, 2021
Merged

Prevent setlocale()-calls from overwriting themselves#38315
phil-davis merged 2 commits intomasterfrom
issues/38303

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 19, 2021

Description

#38286 removed the patchwork/utf8 lib while preserving its functionality. During this, the order of the setlocale()-calls got mixed up, so the values for LC_CTYPE were annihilated by the second call with LC_ALL.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor

phil-davis commented Jan 19, 2021

Maybe add this PR link to the existing unreleased changelog https://github.com/owncloud/core/blob/master/changelog/unreleased/38286

@JammingBen
Copy link
Contributor Author

JammingBen commented Jan 19, 2021 •
edited
Loading

Maybe add this PR link to the existing unreleased changelog https://github.com/owncloud/core/blob/master/changelog/unreleased/38286

Ahhh saw it too late. Will do in a sec

Edit: Done

@owncloud owncloud deleted a comment from update-docs bot Jan 19, 2021
@AlexAndBear
Copy link

AlexAndBear commented Jan 19, 2021

Wow this is reasonable, see also
https://github.com/nicolas-grekas/Patchwork-UTF8/blob/master/src/Patchwork/Utf8/Bootup.php

Good work @JammingBen

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 6342855 into master Jan 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/38303 branch January 19, 2021 12:17
This was referenced Jan 21, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

+1 more reviewer

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Acceptance tests not working locally since the removal of patchwork/utf8

3 participants

@JammingBen @phil-davis @AlexAndBear
X Tutup