Fix a regression with theming of settings menu icons #38246
Merged
phil-davis merged 1 commit intomasterfrom Dec 23, 2020
Merged
Fix a regression with theming of settings menu icons #38246phil-davis merged 1 commit intomasterfrom
phil-davis merged 1 commit intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
11 tasks
Contributor
|
@VicDeo Cool! Can you add a changelog? Fix looks good. |
Member
Author
|
@micbar added |
micbar
reviewed
Dec 22, 2020
micbar
reviewed
Dec 22, 2020
changelog/unreleased/38246
Outdated
| @@ -0,0 +1,6 @@ | |||
| Bugfix: Fix a regression with theming of settings menu icons | |||
|
|
|||
| Default icons were loaded into the settings menu instead of icons | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Default icons were loaded into the settings menu instead of icons | |
| Default icons were loaded instead of the overrides |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Firstly URLGenerator is instantiated when user session is loaded and the theme is not available yet on this stage.
So an empty theme is cached into the URLGenerator instance for a while.
Partially reverts #37867
Related Issue
Motivation and Context
Fixes resolution of images added into the settings navigation by app-themes
How Has This Been Tested?
settings/img/users.svg)Expected
users.svg from theme is loaded
Actual
users.svg from core is loaded.
Types of changes
Checklist: