X Tutup
Skip to content

Rename Phoenix to Web#38199

Merged
phil-davis merged 1 commit intomasterfrom
rename-phoenix-to-web
Dec 9, 2020
Merged

Rename Phoenix to Web#38199
phil-davis merged 1 commit intomasterfrom
rename-phoenix-to-web

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 9, 2020 •
edited
Loading

Description

  • Change the config.php keys phoenix.baseUrl phoenix.icon and phoenix.label to be web.baseUrl web.icon and web.label

  • If the new config.php keys are not set, then check the old keys. This provides backward-compatibility for automated testing and people who are using dev setups etc based on core master. Either key will work while we transition.

Related PR is owncloud/web#4443

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Dec 9, 2020
LukasHirt
LukasHirt approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@LukasHirt LukasHirt mentioned this pull request Dec 9, 2020
Merged
5 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar
Copy link
Contributor

micbar commented Dec 9, 2020 •
edited
Loading

Awesome!
We need a port to the release-10.6.0 branch.

@phil-davis phil-davis merged commit 2abc728 into master Dec 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the rename-phoenix-to-web branch December 9, 2020 14:27
@phil-davis phil-davis mentioned this pull request Dec 9, 2020
Merged
@phil-davis
Copy link
Contributor Author

phil-davis commented Dec 9, 2020

Port to release-10.6.0 is PR #38200

@phil-davis phil-davis mentioned this pull request Dec 9, 2020
Merged
11 tasks
@jnweiger jnweiger mentioned this pull request Apr 6, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@micbar micbar Awaiting requested review from micbar

+1 more reviewer

@refs refs refs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phil-davis @micbar @refs @LukasHirt
X Tutup