Conversation
7447355 to
85704f0
Compare
5ed6213 to
ac39701
Compare
ac39701 to
50d36dd
Compare
50d36dd to
4d204f3
Compare
|
The drone agents + docker "have a bad day" sometimes. https://drone.owncloud.com/owncloud/core/27900/152/8 That is rubbish - the docker image should be pulled from docker if the agent does not already have it. I restarted drone CI. |
I think today drone is not willing to work properly |
4e63255 to
4c50f8b
Compare
|
Some test have not started, services not ready... |
Yes, drone ist really frustrating today.... |
|
|
Thank you, checks passed now |
|
@janackermann
|
|
@mmattel Thank you for your Input!
@pmaier1 @micbar I think we could really get rid of this message, from now it is so clear that these are tags, what do you think?
|
The problem which started this PR is, that many users enter a username in the tags field and think that they have shared the file. The instance we are talking about has a lot of federated shares. But i would suggest to rather remove the message at all. It was an idea to help the users, but seems to be not as helpful as we thought. @janackermann @JammingBen agree? |
I totally agree. In the future, users have to click either on the "tags"-tab, or on the tags directly which will also open the "tags"-tab. So IMO this makes in pretty clear that we are dealing with tags here, not with email addresses. |
|
Message removed |
89d040c to
bdb5c86
Compare
|
@janackermann |
@mmattel Unfortunately Select2 3.5 stops the propagation of most events out of the container so I am not able to catch the events when a tag is just clicked, with Select2 v4, this is no issue any more but needs a bunch of refactoring. I think this would blow up the frame of this PR. |
bdb5c86 to
2992381
Compare
|
Select2 v4 is out of reach of this PR, totally agree. You may file another PR for that... And CI is making us crazy... |
Basically the the lisence of the windows server has been expired, so the server shuts down automatically. |
|
🤦♂️ |
I have no clue 🧐 |
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
left a comment
There was a problem hiding this comment.
Minor comments on the changelog
Description
Introduce a new tab, where the tag input field will be displayed.
1.1 Keyboard navigation in the input field's dropdown works now proper, in the past the user needed to hover over on item in the dropdown before the arrow keys could be used
Replace the tag input field in the file list by a read only tag list.
2.1 Improving tag appearance to clarify that these are tags and no shares.
2.2 Clicking on a tag opens the tag tab.
2.3 Tag tab and tag list are in sync, means that editing (select, unselect, rename, remove) tags will appear in the tag list immediately.
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: