adapted solution for 5xx error on i10n vsprintf#38103
Merged
AlexAndBear merged 1 commit intomasterfrom Nov 17, 2020
Merged
Conversation
|
|
DeepDiver1975
requested changes
Nov 13, 2020
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Please add a unit test for this. THX
phil-davis
reviewed
Nov 13, 2020
DeepDiver1975
requested changes
Nov 13, 2020
DeepDiver1975
requested changes
Nov 13, 2020
Member
|
squash commits into one and we are ready to go @HieronymusPerro - THX |
AlexAndBear
force-pushed
the
issues/37799
branch
from
26a202f to
8d7670e
Compare
Author
|
Done, THX for reviewing! @DeepDiver1975 |
DeepDiver1975
approved these changes
Nov 16, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As we using the vsprintf links in the i10n translation provider and also translations provided via the community, there is always the possibility, that there might be an error in the translation string.
Especially if there is an unescaped % char in the text, without any parameter, this will provoke an error in the WebUi (Error Page).
Instead of showing a 5xx Error, the original text will be displayed.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: