X Tutup
Skip to content

Use the right l10n object if the template is loaded from another app#38072

Merged
phil-davis merged 2 commits intomasterfrom
adjust_template_translations
Nov 3, 2020
Merged

Use the right l10n object if the template is loaded from another app#38072
phil-davis merged 2 commits intomasterfrom
adjust_template_translations

Conversation

@jvillafanez
Copy link
Member

Description

Some apps can include template parts from a different app, normally from core. From example, the activity app can include content from the core templates to be used in the activity email.
The translated strings where picked from the original app even though the template was loaded from core. As a result, some string weren't translated because the missing translation for those strings in the original app. Note that core had the string correctly translated.

Related Issue

https://github.com/owncloud/enterprise/issues/4249

Motivation and Context

How Has This Been Tested?

Manually tested with a custom theme, which loads some core content in the activity app.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Nov 3, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 0d18db0 into master Nov 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust_template_translations branch November 3, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup