Refactor getSharesInDir method and allow new interaction in params#38053
Merged
karakayasemi merged 2 commits intomasterfrom Nov 7, 2020
Merged
Refactor getSharesInDir method and allow new interaction in params#38053karakayasemi merged 2 commits intomasterfrom
karakayasemi merged 2 commits intomasterfrom
Conversation
"subfiles" param in the getShares request can interact with "reshares" and the new "share_types" params. The "path" param is still required if "subfiles" is present. There are no changes regarding the "shared_with_me" param
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
karakayasemi
approved these changes
Nov 7, 2020
Contributor
karakayasemi
left a comment
karakayasemi
left a comment
There was a problem hiding this comment.
As far as I see, the consumer of getSharesIndir already makes all the checks that getSharesIndir has. So, removing it makes sense to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"subfiles" param in the getShares request can interact with "reshares"
and the new "share_types" params. The "path" param is still required if
"subfiles" is present.
There are no changes regarding the "shared_with_me" param
Description
The "subfiles" parameter in the getShares request had some additional restrictions which weren't documented. This PR remove those restrictions and allows interaction with the rest of the parameters (except the "share_with_me", which remain the same
Related Issue
No opened issue.
Follow up of #38000
Motivation and Context
there is no reason to limit the interaction of the "reshares" and "share_types" parameters with the "subfiles" one.
How Has This Been Tested?
Checked manually via API
Screenshots (if appropriate):
Types of changes
Checklist: