X Tutup
Skip to content

Fixes https://github.com/owncloud/openidconnect/issues/112 for all apps#38037

Merged
VicDeo merged 1 commit intomasterfrom
bugfix/openid-112
Oct 30, 2020
Merged

Fixes https://github.com/owncloud/openidconnect/issues/112 for all apps#38037
VicDeo merged 1 commit intomasterfrom
bugfix/openid-112

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 26, 2020 •
edited
Loading

Description

Some apps use the variable $app in app.php - this overwrites the variable in requireAppFile and causes the error

Related Issue

How Has This Been Tested?

  • ✋

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 requested a review from VicDeo October 26, 2020 11:46
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 26, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

VicDeo
VicDeo approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@owncloud owncloud deleted a comment from update-docs bot Oct 30, 2020
@VicDeo VicDeo merged commit d88f62e into master Oct 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/openid-112 branch October 30, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VicDeo VicDeo VicDeo approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Message: Object of class OCA\OpenIdConnect\Application could not be converted to string

2 participants

@DeepDiver1975 @VicDeo
X Tutup