X Tutup
Skip to content

Update symfony/polyfill (1.18.1 => 1.19.0)#38032

Merged
phil-davis merged 2 commits intomasterfrom
bump-polyfill
Oct 24, 2020
Merged

Update symfony/polyfill (1.18.1 => 1.19.0)#38032
phil-davis merged 2 commits intomasterfrom
bump-polyfill

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 23, 2020 •
edited
Loading

Description

  1. Update symfony/polyfill dependencies
$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 10 updates, 0 removals
  - Updating symfony/polyfill-iconv (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-php72 (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-php70 (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-intl-normalizer (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-intl-idn (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-mbstring (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-php73 (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-php80 (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating symfony/polyfill-ctype (v1.18.1 => v1.19.0): Downloading (100%)         
  - Updating roave/security-advisories (dev-master ba5d234 => dev-master 3273709)
  1. Something in phpstan 0.12.51release means that it now complains about unsetting an undefined variable. In this case the variable gets "imported" from config.php so phpstan has no idea about it. Suppress the error messages.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added 3 - To Review dependencies php Pull requests that update Php code labels Oct 23, 2020
@phil-davis phil-davis self-assigned this Oct 23, 2020
@phil-davis
Copy link
Contributor Author

phil-davis commented Oct 23, 2020

A new release of phpstan 0.12.51 starts reporting:

------ --------------------------------------------------------------- 
  Line   lib/private/Config.php                                         
 ------ --------------------------------------------------------------- 
  253    Call to function unset() contains undefined variable $CONFIG.  
  255    Undefined variable: $CONFIG                                    
 ------ --------------------------------------------------------------- 

 [ERROR] Found 2 errors

That method gets $CONFIG by including the config file.

Add phpstan-ignore-next-line annotation to suppress the "errors".

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 5db6af5 into master Oct 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-polyfill branch October 24, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrow4a mrow4a mrow4a approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@micbar micbar Awaiting requested review from micbar

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

@VicDeo VicDeo Awaiting requested review from VicDeo

Assignees

@phil-davis phil-davis

Labels

3 - To Review dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @mrow4a
X Tutup