X Tutup
Skip to content

Feature/pre signed url ajax download#38029

Merged
DeepDiver1975 merged 2 commits intomasterfrom
feature/pre-signed-url-ajax-download
Oct 26, 2020
Merged

Feature/pre signed url ajax download#38029
DeepDiver1975 merged 2 commits intomasterfrom
feature/pre-signed-url-ajax-download

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 22, 2020 •
edited
Loading

Description

  • ajax/download can now be used with pre-signed urls
  • OC-Algo was added to give the client a chance to use less computaion effort (bloody ie11 as example)

How Has This Been Tested?

  • ✋
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 self-assigned this Oct 22, 2020
@DeepDiver1975 DeepDiver1975 force-pushed the feature/pre-signed-url-ajax-download branch 2 times, most recently from 61bdc9e to 6c1d4e1 Compare October 22, 2020 09:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

C0rby
C0rby approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/private/legacy/util.php Outdated
return $errors;
}

private static function checkPreSigneUrl() {
Copy link
Contributor

@C0rby C0rby Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a 'd' is missing here checkPreSigne**d**Url

@phil-davis
Copy link
Contributor

phil-davis commented Oct 22, 2020

I don't see any changelog, but the changelog bot has no posted its usual message about needing a changelog.

@DeepDiver1975 DeepDiver1975 marked this pull request as draft October 22, 2020 12:52
@DeepDiver1975 DeepDiver1975 force-pushed the feature/pre-signed-url-ajax-download branch from 6c1d4e1 to 17d62f1 Compare October 22, 2020 13:06
@mmattel
Copy link
Contributor

mmattel commented Oct 22, 2020

Is there a docs impact ?
Needs mentioning?

@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review October 23, 2020 14:57
@DeepDiver1975 DeepDiver1975 force-pushed the feature/pre-signed-url-ajax-download branch from 17d62f1 to 3a7c51d Compare October 23, 2020 14:58
@DeepDiver1975 DeepDiver1975 force-pushed the feature/pre-signed-url-ajax-download branch from 3a7c51d to 3b4bca0 Compare October 26, 2020 11:02
@DeepDiver1975 DeepDiver1975 merged commit 3c6871e into master Oct 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/pre-signed-url-ajax-download branch October 26, 2020 14:19
@mmattel
Copy link
Contributor

mmattel commented Oct 26, 2020

@DeepDiver1975 mind to let us know if there is a doc change necessary? (see my comment above)

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Oct 26, 2020

@DeepDiver1975 mind to let us know if there is a doc change necessary? (see my comment above)

it depends on it this feature is documented at all at the moment .... if so the new parameter OC-Algo need to be added.

@mmattel mmattel mentioned this pull request Oct 27, 2020
Open
12 tasks
@mmattel
Copy link
Contributor

mmattel commented Oct 28, 2020

Sorry to bother, but there is still no changelog for this PR 38029 present, can´t be found in https://github.com/owncloud/core/tree/master/changelog/unreleased

@DeepDiver1975 @phil-davis

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Oct 28, 2020

Sorry to bother, but there is still no changelog for this PR 38029 present, can´t be found in https://github.com/owncloud/core/tree/master/changelog/unreleased

https://github.com/owncloud/core/pull/38029/files#diff-6de73cad10994edb1c8a70a9f53e2aa135ccc7d94973b16118355ed858c0fc64

@mmattel
Copy link
Contributor

mmattel commented Oct 28, 2020

@DeepDiver1975 maybe I have missed that, but there is no change description (a text like Enhancement:...) for this (38029) PR.
If you look into https://github.com/owncloud/core/tree/master/changelog/unreleased, no entry for 30829 is made and the reference 37634 is without text too and circular to 38029...? Intended?

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Oct 28, 2020

The changelog item 37634 holds a ref to this PR - this is enough - it all belongs to the same change.

Screenshot from 2020-10-28 18-21-21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@butonic butonic Awaiting requested review from butonic

1 more reviewer

@C0rby C0rby C0rby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @phil-davis @mmattel @C0rby
X Tutup