check request token on cookie authenticated request#38019
Merged
Conversation
C0rby
force-pushed
the
fix-request-token-check
branch
2 times, most recently
from
51bf89a to
e63bcf3
Compare
Contributor
Author
|
Wtf was that condition before? |
Contributor
Author
|
Oh this looks promising. Restarting the tests because there was a network timeout |
Contributor
Author
|
Did some manual smoke testing with the android app and the browser. Nothing seems to be broken there. |
Contributor
|
Changelog? Ready for review? |
Contributor
Author
|
Yeah, I forgot the changelog. Will add it now. |
C0rby
force-pushed
the
fix-request-token-check
branch
from
e63bcf3 to
3b4027f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
IljaN
approved these changes
Nov 12, 2020
Contributor
IljaN
left a comment
IljaN
left a comment
There was a problem hiding this comment.
Did a quick smoke-test by sharing and creating public links from the desktop ✔️
LGTM 🍻
micbar
approved these changes
Nov 12, 2020
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check the request token on cookie authorized requests.
Motivation and Context
Since the OCS_APIREQUEST header was removed we needed another way to restrict cookie authenticated requests.
How Has This Been Tested?
Types of changes
Checklist: