X Tutup
Skip to content

Clean preferences only if they exist#37947

Merged
phil-davis merged 2 commits intomasterfrom
user_sync_pref_deletion
Sep 29, 2020
Merged

Clean preferences only if they exist#37947
phil-davis merged 2 commits intomasterfrom
user_sync_pref_deletion

Conversation

@jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented Sep 25, 2020

Description

Remove the user's preferences only if they exist. This will prevent triggering the userpreferences.afterDeleteValue event while syncing users

Related Issue

https://github.com/owncloud/enterprise/issues/4212

Motivation and Context

How Has This Been Tested?

Manually tested just syncing the users via occ command

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez requested a review from micbar September 25, 2020 12:57
@jvillafanez jvillafanez self-assigned this Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #37947 into master will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37947   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
- Complexity    19442    19444    +2     
=========================================
  Files          1286     1286           
  Lines         76022    76025    +3     
  Branches       1336     1336           
=========================================
+ Hits          49196    49198    +2     
- Misses        26432    26433    +1     
  Partials        394      394
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <85.71%> (+<0.01%) 19444.00 <2.00> (+2.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/User/SyncService.php 82.85% <85.71%> (-0.29%) 63.00 <2.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a444c5...1fcd200. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Sep 29, 2020
@phil-davis phil-davis merged commit 9ef0667 into master Sep 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the user_sync_pref_deletion branch September 29, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@micbar micbar micbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jvillafanez jvillafanez

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvillafanez @micbar @phil-davis
X Tutup