Add new defaults for the icon and label of the phoenix menu item#37923
Merged
Add new defaults for the icon and label of the phoenix menu item#37923
Conversation
|
|
Contributor
|
Nice work, thanks!
Yes, please! |
When phoenix is configured (phoenix.baseUrl in config.php), the app switcher has a menu item for Phoenix. This now has a new and configurable default icon and default label.
kulmann
force-pushed
the
phoenix-default-menu-item
branch
from
2a7ab37 to
d042b65
Compare
DeepDiver1975
requested changes
Sep 21, 2020
micbar
approved these changes
Sep 21, 2020
Contributor
Author
|
@micbar codecov results are missing... |
Contributor
|
codecov results are almost always missing in core. I had a support ticket about that - https://codecov.freshdesk.com/support/tickets/3634 - but no joy yet. Some days the results get posted back to GitHub, some days not. |
Contributor
Author
|
Ah, ok. Thanks for explaining @phil-davis :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When phoenix is configured (phoenix.baseUrl in config.php), the app switcher has a menu item for Phoenix. This now has a new and configurable default icon and default label, as discussed and decided by the design initiative last week.
Open question: Is it relevant to have translations for the menu item label?
Related Issue
Motivation and Context
Make it easier for users to spot the switch to the new design.
How Has This Been Tested?
✋
Screenshots (if appropriate):
Types of changes
Checklist: