Reduce the log level for locked exceptions#37907
Merged
phil-davis merged 4 commits intomasterfrom Sep 29, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37907 +/- ##
============================================
- Coverage 64.71% 64.71% -0.01%
- Complexity 19442 19444 +2
============================================
Files 1286 1286
Lines 76019 76021 +2
Branches 1336 1336
============================================
+ Hits 49196 49197 +1
- Misses 26429 26430 +1
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jvillafanez
force-pushed
the
reduce_locked_exception_level
branch
from
69f8817 to
78acfd1
Compare
micbar
reviewed
Sep 28, 2020
Contributor
micbar
left a comment
micbar
left a comment
There was a problem hiding this comment.
Needs a changelog, rest looks fine
micbar
approved these changes
Sep 28, 2020
phil-davis
force-pushed
the
reduce_locked_exception_level
branch
from
4251069 to
4decd46
Compare
Contributor
|
Rebased to get good CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the log level of locked exceptions to debug instead of fatal.
Related Issue
https://github.com/owncloud/enterprise/issues/4184
Motivation and Context
Locked exceptions could happen naturally if the file is effectively locked. This is normal behaviour, and as such, it shouldn't cause fatal exceptions. We'll use a debug log instead in order to track possible problems.
How Has This Been Tested?
A locked exception is shown with a debug log level.
The same happens if the folder is locked and you try to upload a new file inside.
Screenshots (if appropriate):
Types of changes
Checklist: