Very minimal empty ODF files#37896
Conversation
These files contain no data at all. This guarantees that when the user opens a new document in the richdocuments app, the language of paragraph, page size, cell date format, currency, etc. will be according to the current locale.
|
|
|
@phil-davis can you retrigger codecov, seems to be stuck... |
|
codecov/patch is always stuck these days - it always says "In progress - This step has started..." and no result comes. I have had to override the result for every PR to core in the last week or more. |
|
@micbar please get the appropriate person to review this... |
|
@phil-davis @DeepDiver1975 Background? Changelog? |
|
@timar can you please file a changelog, see: https://github.com/owncloud/core/blob/master/changelog/README.md |
I don't know - I just got mentioned regarding codecov. |
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Codecov Report
@@ Coverage Diff @@
## master #37896 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19403 19403
=========================================
Files 1285 1285
Lines 75823 75823
Branches 1336 1336
=========================================
Hits 49096 49096
Misses 26333 26333
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Co-authored-by: Phil Davis <phil@jankaritech.com>
mmattel
left a comment
mmattel
left a comment
There was a problem hiding this comment.
LGTM (but not tested with the richdocument app because not installed)
Codecov Report
@@ Coverage Diff @@
## master #37896 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19403 19403
=========================================
Files 1285 1285
Lines 75823 75823
Branches 1336 1336
=========================================
Hits 49096 49096
Misses 26333 26333
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Stupid codecov. I tried to fake the results, but it comes in "over the top" with its own silly result. @micbar please force merge. |
|
@micbar ping (force merge, see comment of @phil-davis above) |
Signed-off-by: Andras Timar <andras.timar@collabora.com>
5 participants
These files contain no data at all. This guarantees that when the
user opens a new document in the richdocuments app, the language
of paragraph, page size, cell date format, currency, etc. will be
according to the current locale.