Fix application id used for sharing settings translation#37846
Merged
Conversation
VicDeo
changed the title
VicDeo
force-pushed
the
bugfix/e4168
branch
2 times, most recently
from
580cb15 to
39fc0f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #37846 +/- ##
============================================
- Coverage 64.75% 64.74% -0.01%
Complexity 19396 19396
============================================
Files 1285 1285
Lines 75762 75762
Branches 1333 1333
============================================
- Hits 49057 49055 -2
- Misses 26313 26315 +2
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jvillafanez
approved these changes
Aug 25, 2020
Contributor
|
codecov/patch is not going to come - that is failing to come nearly all the time these days. Someone needs to decide if the codecov/project result is acceptable, and merge... |
Contributor
|
##Retested with 10.6.0 RC1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
'lib' was passed as the app name into the sharing settings panel instead of 'settings'
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: