X Tutup
Skip to content

[tests-only] Add wait_for_ci: false to codecov settings#37832

Closed
phil-davis wants to merge 3 commits intomasterfrom
adjust-codecov-settings
Closed

[tests-only] Add wait_for_ci: false to codecov settings#37832
phil-davis wants to merge 3 commits intomasterfrom
adjust-codecov-settings

Conversation

@phil-davis
Copy link
Contributor

Description

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #37832 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37832      +/-   ##
============================================
- Coverage     64.75%   64.50%   -0.25%     
  Complexity    19392    19392              
============================================
  Files          1284     1284              
  Lines         75755    75755              
  Branches       1333     1333              
============================================
- Hits          49057    48868     -189     
- Misses        26306    26495     +189     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.66% <ø> (-0.28%) 19392.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0.00% <0.00%> (-86.67%) 4.00% <0.00%> (ø%)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0.00% <0.00%> (-85.19%) 18.00% <0.00%> (ø%)
lib/private/DB/OracleMigrator.php 0.00% <0.00%> (-76.85%) 10.00% <0.00%> (ø%)
lib/private/DB/OracleConnection.php 0.00% <0.00%> (-63.89%) 12.00% <0.00%> (ø%)
lib/private/DB/ConnectionFactory.php 79.72% <0.00%> (-6.76%) 22.00% <0.00%> (ø%)
lib/private/DB/Adapter.php 82.71% <0.00%> (-6.18%) 25.00% <0.00%> (ø%)
lib/private/Repair/RepairMismatchFileCachePath.php 94.55% <0.00%> (-3.51%) 51.00% <0.00%> (ø%)
lib/private/Repair/RepairInvalidShares.php 97.26% <0.00%> (-2.74%) 17.00% <0.00%> (ø%)
lib/private/AllConfig.php 94.33% <0.00%> (-1.89%) 43.00% <0.00%> (ø%)
lib/private/Files/Cache/Cache.php 95.88% <0.00%> (-1.77%) 107.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e4f61...60bd3ed. Read the comment docs.

@phil-davis phil-davis mentioned this pull request Aug 27, 2020
11 tasks
@phil-davis
Copy link
Contributor Author

codecov started working again last week. It seemed to break again late in the week, but at the weekend and this morning it worked - e.g. #37922

We should not need to tweak settings.

@phil-davis phil-davis closed this Sep 21, 2020
@phil-davis phil-davis deleted the adjust-codecov-settings branch September 21, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

X Tutup