X Tutup
Skip to content

[Tests-only] copy certificates to server storage during testing#37787

Merged
phil-davis merged 1 commit intomasterfrom
issue-37784
Aug 9, 2020
Merged

[Tests-only] copy certificates to server storage during testing#37787
phil-davis merged 1 commit intomasterfrom
issue-37784

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 7, 2020

Description

In the acceptance tests for the occ security:certificates commands, use the testing app to copy the certificate files into a temporary directory on the system-under-test and import the certificates from the temporary directory. This avoids problems when the test-runner and the system-under-test are in different file-systems.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #37787 into master will decrease coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37787      +/-   ##
============================================
- Coverage     64.71%   64.70%   -0.01%     
- Complexity    19391    19392       +1     
============================================
  Files          1284     1284              
  Lines         75753    75757       +4     
  Branches       1333     1333              
============================================
+ Hits          49021    49022       +1     
- Misses        26340    26343       +3     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <16.66%> (-0.01%) 19392.00 <0.00> (+1.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
core/Command/Security/ImportCertificate.php 0.00% <0.00%> (ø) 4.00 <0.00> (ø)
core/Command/Security/RemoveCertificate.php 0.00% <0.00%> (ø) 4.00 <0.00> (+1.00)
lib/private/Security/CertificateManager.php 89.01% <100.00%> (+0.12%) 35.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a865a3...4195dae. Read the comment docs.

@phil-davis phil-davis merged commit 786defa into master Aug 9, 2020
@phil-davis phil-davis deleted the issue-37784 branch August 9, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

securityCertificates.feature is failing when run against a system-under-test from tarball

2 participants

X Tutup