X Tutup
Skip to content

Update symfony/polyfill (1.17.0 => 1.18.0)#37694

Merged
phil-davis merged 1 commit intomasterfrom
symfony-polyfill-1.18.0
Jul 16, 2020
Merged

Update symfony/polyfill (1.17.0 => 1.18.0)#37694
phil-davis merged 1 commit intomasterfrom
symfony-polyfill-1.18.0

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 16, 2020

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 3 installs, 7 updates, 0 removals
  - Updating symfony/polyfill-iconv (v1.17.1 => v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-php72 (v1.17.0 => v1.18.0): Downloading (100%)         
  - Installing paragonie/random_compat (v9.99.99): Loading from cache
  - Installing symfony/polyfill-php70 (v1.18.0): Downloading (100%)         
  - Installing symfony/polyfill-intl-normalizer (v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-intl-idn (v1.17.1 => v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-mbstring (v1.17.1 => v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-php73 (v1.17.1 => v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-php80 (v1.17.1 => v1.18.0): Downloading (100%)         
  - Updating symfony/polyfill-ctype (v1.17.1 => v1.18.0): Downloading (100%)

IMO there is nothing specially important for 10.5.0 here. So this can just go in master and will end up in a future release.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added 3 - To Review dependencies php Pull requests that update Php code labels Jul 16, 2020
@phil-davis phil-davis requested a review from individual-it July 16, 2020 04:02
@phil-davis phil-davis self-assigned this Jul 16, 2020
@individual-it
Copy link
Member

individual-it commented Jul 16, 2020

CI failed with DNS issues, restarted

@codecov
Copy link

codecov bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #37694 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37694   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19386    19386           
=========================================
  Files          1283     1283           
  Lines         75730    75730           
  Branches       1333     1333           
=========================================
  Hits          49008    49008           
  Misses        26330    26330           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19386.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebe325...b474d3d. Read the comment docs.

@phil-davis phil-davis merged commit 5257732 into master Jul 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the symfony-polyfill-1.18.0 branch July 16, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels

3 - To Review dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @individual-it
X Tutup