X Tutup
Skip to content

[10.5.0] Fix for centering the credential fields on IE11#37693

Merged
micbar merged 1 commit intorelease-10.5.0from
fix-ie11-credential-fields-10.5.0
Jul 15, 2020
Merged

[10.5.0] Fix for centering the credential fields on IE11#37693
micbar merged 1 commit intorelease-10.5.0from
fix-ie11-credential-fields-10.5.0

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 15, 2020

Description

In IE11 the input fields for user and password were not centered.

Related Issue

#37690

Motivation and Context

Even users of old browsers should experience centered input fields.
However, this does not change the fact that IE11 should no longer be used, dear folks.

How Has This Been Tested?

  • Manually tested in IE11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis requested a review from micbar July 15, 2020 07:23
@phil-davis phil-davis self-assigned this Jul 15, 2020
@phil-davis phil-davis mentioned this pull request Jul 15, 2020
Closed
11 tasks
@phil-davis phil-davis changed the title Fix for centering the credential fields on IE11 [10.5.0] Fix for centering the credential fields on IE11 Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020 •
edited
Loading

Codecov Report

Merging #37693 into release-10.5.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.5.0   #37693   +/-   ##
=================================================
  Coverage             64.74%   64.74%           
  Complexity            19363    19363           
=================================================
  Files                  1281     1281           
  Lines                 75628    75628           
  Branches               1333     1333           
=================================================
  Hits                  48966    48966           
  Misses                26270    26270           
  Partials                392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (ø) 19363.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4107e...15fb95f. Read the comment docs.

@micbar micbar merged commit 95ff6f2 into release-10.5.0 Jul 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-ie11-credential-fields-10.5.0 branch July 15, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@micbar micbar micbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @micbar
X Tutup