X Tutup
Skip to content

The response of LOCK shall hold the updated owner set by the LockManager#37647

Merged
phil-davis merged 1 commit intomasterfrom
bugfix/response-of-lock-needs-to-update-the-owner
Jul 3, 2020
Merged

The response of LOCK shall hold the updated owner set by the LockManager#37647
phil-davis merged 1 commit intomasterfrom
bugfix/response-of-lock-needs-to-update-the-owner

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 3, 2020 •
edited
Loading

Description

In case the owner is updated by the server within the LOCK operation the updated owner value needs to be sent back to the client

How Has This Been Tested?

  • ✋

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 3, 2020
Closed
11 tasks
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/response-of-lock-needs-to-update-the-owner branch from 65c3c95 to c4a693c Compare July 3, 2020 10:26
@DeepDiver1975 DeepDiver1975 self-assigned this Jul 3, 2020
phil-davis
phil-davis reviewed Jul 3, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 3, 2020 •
edited
Loading

Codecov Report

Merging #37647 into master will increase coverage by 20.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #37647       +/-   ##
=============================================
+ Coverage     44.32%   64.74%   +20.41%     
- Complexity        0    19360    +19360     
=============================================
  Files           111     1281     +1170     
  Lines         10967    75622    +64655     
  Branches       1333     1333               
=============================================
+ Hits           4861    48959    +44098     
- Misses         5714    26271    +20557     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.92% <100.00%> (+42.84%) 19360.00 <0.00> (+19360.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Lock/Persistent/LockManager.php 98.30% <100.00%> (ø) 23.00 <0.00> (?)
lib/private/Http/Client/Response.php 53.84% <0.00%> (ø) 6.00% <0.00%> (?%)
lib/private/DB/SQLiteMigrator.php 100.00% <0.00%> (ø) 7.00% <0.00%> (?%)
...v/lib/Connector/Sabre/Exception/EntityTooLarge.php 0.00% <0.00%> (ø) 1.00% <0.00%> (?%)
settings/Panels/Admin/Logging.php 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)
apps/dav/lib/Avatars/AvatarNode.php 72.00% <0.00%> (ø) 9.00% <0.00%> (?%)
lib/public/Util.php 58.85% <0.00%> (ø) 81.00% <0.00%> (?%)
lib/private/Command/QueueBus.php 84.61% <0.00%> (ø) 6.00% <0.00%> (?%)
lib/private/Files/External/PriorityTrait.php 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...ilesharing/templates/settings-personal-general.php 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 1163 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cac52e...8c1c3fb. Read the comment docs.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/response-of-lock-needs-to-update-the-owner branch from c4a693c to 17178bf Compare July 3, 2020 12:04
@DeepDiver1975 DeepDiver1975 requested a review from phil-davis July 3, 2020 12:05
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/response-of-lock-needs-to-update-the-owner branch from 17178bf to 8c1c3fb Compare July 3, 2020 12:12
phil-davis
phil-davis approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@owncloud owncloud deleted a comment from update-docs bot Jul 3, 2020
@phil-davis phil-davis merged commit fb7950d into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/response-of-lock-needs-to-update-the-owner branch July 3, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeepDiver1975 @phil-davis
X Tutup