X Tutup
Skip to content

[Tests-Only] Use laminas-ldap in acceptance tests#37613

Merged
phil-davis merged 1 commit intomasterfrom
laminas-ldap-accceptance-tests
Jun 30, 2020
Merged

[Tests-Only] Use laminas-ldap in acceptance tests#37613
phil-davis merged 1 commit intomasterfrom
laminas-ldap-accceptance-tests

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 30, 2020

Description

zendframework became known as laminas from 2020-01-01. PR #36677 made the change to the core composer.json and code.

One occurrence in acceptance tests was left behind. This PR changes that to laminas/laminas-ldap

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis requested a review from individual-it June 30, 2020 04:52
@phil-davis phil-davis self-assigned this Jun 30, 2020
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #37613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37613   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75614    75614           
  Branches       1333     1333           
=========================================
  Hits          48926    48926           
  Misses        26296    26296           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19353.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc76b2...74c792d. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #37613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37613   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75614    75614           
  Branches       1333     1333           
=========================================
  Hits          48926    48926           
  Misses        26296    26296           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19353.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc76b2...74c792d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #37613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37613   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75614    75614           
  Branches       1333     1333           
=========================================
  Hits          48926    48926           
  Misses        26296    26296           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19353.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc76b2...74c792d. Read the comment docs.

@phil-davis phil-davis merged commit fad90b8 into master Jun 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the laminas-ldap-accceptance-tests branch June 30, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels

3 - To Review dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @individual-it
X Tutup