X Tutup
Skip to content

Adjust login wording on login page#37604

Merged
phil-davis merged 1 commit intomasterfrom
issue-37603
Jun 26, 2020
Merged

Adjust login wording on login page#37604
phil-davis merged 1 commit intomasterfrom
issue-37603

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 26, 2020

Description

Adjust the use of "log in" vs "login" as per comments in issue at #37603 (comment)

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis requested a review from jnweiger June 26, 2020 10:11
@phil-davis phil-davis self-assigned this Jun 26, 2020
@phil-davis phil-davis mentioned this pull request Jun 26, 2020
Closed
@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 26, 2020

Note: if/when this is merged, then resulting Transifex translation changes will need to come back over the next days. Then decide if we port this (and the translation changes) back to release-10.5.0.

"Login" already exists in translations, so that will not cause a problem. But the change to "You took too long to log in, please try again now" will cause translation to need to be updated.

jnweiger
jnweiger approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@codecov
Copy link

codecov bot commented Jun 26, 2020 •
edited
Loading

Codecov Report

Merging #37604 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37604   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19353    19353           
=========================================
  Files          1281     1281           
  Lines         75614    75614           
  Branches       1333     1333           
=========================================
  Hits          48926    48926           
  Misses        26296    26296           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19353.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
core/templates/login.php 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad274cb...afb794c. Read the comment docs.

@phil-davis phil-davis merged commit a5c1be8 into master Jun 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-37603 branch June 26, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jnweiger jnweiger jnweiger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@phil-davis phil-davis

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent use of "Login" and "Log in"

2 participants

@phil-davis @jnweiger
X Tutup