X Tutup
Skip to content

Handle application/gzip when installing apps on PHP 7.4#37559

Merged
DeepDiver1975 merged 1 commit intomasterfrom
issue-37467
Jun 19, 2020
Merged

Handle application/gzip when installing apps on PHP 7.4#37559
DeepDiver1975 merged 1 commit intomasterfrom
issue-37467

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 19, 2020

Description

In PHP 7.4 the mime-type of a gzip file is now application/gzip rather than application/x-gzip. See the issue for details.

Allow application/gzip mine-time when doing market:install

Related Issue

How Has This Been Tested?

Manually before:

$ php --version
PHP 7.4.7 (cli) (built: Jun 12 2020 07:44:05) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.7, Copyright (c), by Zend Technologies
    with Xdebug v2.9.6, Copyright (c) 2002-2020, by Derick Rethans
$ php occ market:install activity
activity: Installing new app ...
 activity: Archives of type application/gzip are not supported

And after the code fix:

$ php occ market:install activity
activity: Installing new app ...
activity: App installed.

Ack to @fmkaiser for providing the fix in the issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jun 19, 2020
@update-docs
Copy link

update-docs bot commented Jun 19, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis phil-davis mentioned this pull request Jun 19, 2020
Closed
@phil-davis
Copy link
Contributor Author

phil-davis commented Jun 19, 2020

IMO a changelog is not needed. 10.5.0 has not been released yet, and this is "just" more code changes to support PHP 7.4, and there is already a changelog done for that.

mmattel
mmattel reviewed Jun 19, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37559 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37559      +/-   ##
============================================
- Coverage     64.66%   64.66%   -0.01%     
- Complexity    19343    19345       +2     
============================================
  Files          1279     1279              
  Lines         75600    75601       +1     
  Branches       1333     1333              
============================================
  Hits          48885    48885              
- Misses        26323    26324       +1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <50.00%> (-0.01%) 19345.00 <0.00> (+2.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/Archive.php 65.00% <0.00%> (-3.43%) 11.00 <0.00> (+1.00) ⬇️
lib/private/Installer.php 48.18% <100.00%> (ø) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72fd5...347d341. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37559 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37559      +/-   ##
============================================
- Coverage     64.66%   64.66%   -0.01%     
- Complexity    19343    19345       +2     
============================================
  Files          1279     1279              
  Lines         75600    75601       +1     
  Branches       1333     1333              
============================================
  Hits          48885    48885              
- Misses        26323    26324       +1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <50.00%> (-0.01%) 19345.00 <0.00> (+2.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/Archive.php 65.00% <0.00%> (-3.43%) 11.00 <0.00> (+1.00) ⬇️
lib/private/Installer.php 48.18% <100.00%> (ø) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72fd5...347d341. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37559 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37559      +/-   ##
============================================
- Coverage     64.66%   64.66%   -0.01%     
- Complexity    19343    19345       +2     
============================================
  Files          1279     1279              
  Lines         75600    75601       +1     
  Branches       1333     1333              
============================================
  Hits          48885    48885              
- Misses        26323    26324       +1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <50.00%> (-0.01%) 19345.00 <0.00> (+2.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/Archive.php 65.00% <0.00%> (-3.43%) 11.00 <0.00> (+1.00) ⬇️
lib/private/Installer.php 48.18% <100.00%> (ø) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72fd5...347d341. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37559 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37559      +/-   ##
============================================
- Coverage     64.66%   64.66%   -0.01%     
- Complexity    19343    19345       +2     
============================================
  Files          1279     1279              
  Lines         75600    75601       +1     
  Branches       1333     1333              
============================================
  Hits          48885    48885              
- Misses        26323    26324       +1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <50.00%> (-0.01%) 19345.00 <0.00> (+2.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/Archive.php 65.00% <0.00%> (-3.43%) 11.00 <0.00> (+1.00) ⬇️
lib/private/Installer.php 48.18% <100.00%> (ø) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72fd5...347d341. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #37559 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37559      +/-   ##
============================================
- Coverage     64.66%   64.66%   -0.01%     
- Complexity    19343    19345       +2     
============================================
  Files          1279     1279              
  Lines         75600    75601       +1     
  Branches       1333     1333              
============================================
  Hits          48885    48885              
- Misses        26323    26324       +1     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.83% <50.00%> (-0.01%) 19345.00 <0.00> (+2.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/Archive.php 65.00% <0.00%> (-3.43%) 11.00 <0.00> (+1.00) ⬇️
lib/private/Installer.php 48.18% <100.00%> (ø) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab72fd5...347d341. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 49c3e8f into master Jun 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-37467 branch June 19, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmattel mmattel mmattel left review comments

@jvillafanez jvillafanez jvillafanez approved these changes

@VicDeo VicDeo Awaiting requested review from VicDeo

@micbar micbar Awaiting requested review from micbar

Assignees

@phil-davis phil-davis

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10.5beta1 PHP 7.4 - Cannot install apps from Market - Archives of type application/gzip are not supported - fileinfo magic

4 participants

@phil-davis @jvillafanez @mmattel @DeepDiver1975
X Tutup