X Tutup
Skip to content

Fix the alignment of the cancel button (public uploads)#37504

Merged
phil-davis merged 1 commit intomasterfrom
fix-cancel-button
Jun 11, 2020
Merged

Fix the alignment of the cancel button (public uploads)#37504
phil-davis merged 1 commit intomasterfrom
fix-cancel-button

Conversation

@ChrisEdS
Copy link

@ChrisEdS ChrisEdS commented Jun 9, 2020

Description

The cancel button was not properly centered.

How Has This Been Tested?

  • Manually tested

Screenshots:

Before:
Screenshot 2020-06-09 at 12 27 45

After:
Screenshot 2020-06-09 at 12 28 36

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS requested a review from phil-davis June 9, 2020 10:34
@ChrisEdS ChrisEdS self-assigned this Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #37504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37504   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19336    19336           
=========================================
  Files          1278     1278           
  Lines         75562    75562           
  Branches       1331     1331           
=========================================
  Hits          48876    48876           
  Misses        26294    26294           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <ø> (ø) 19336.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a047e...50a7175. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Jun 11, 2020
@phil-davis phil-davis merged commit b173da0 into master Jun 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-cancel-button branch June 11, 2020 13:29
@davitol davitol mentioned this pull request Jun 25, 2020
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@ChrisEdS ChrisEdS

Labels

4 - To release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisEdS @phil-davis
X Tutup