X Tutup
Skip to content

Change the behavior of the header menus#37490

Merged
phil-davis merged 1 commit intomasterfrom
menu-improvements
Jun 11, 2020
Merged

Change the behavior of the header menus#37490
phil-davis merged 1 commit intomasterfrom
menu-improvements

Conversation

@ChrisEdS
Copy link

@ChrisEdS ChrisEdS commented Jun 7, 2020 •
edited
Loading

Description

Included in this PR:

  • Dynamically adjusting the width of the left menu
  • Changed the centering of the icons
  • Automatic wrap to a second line after the third entry
  • Hover effect in the left and right menu

Motivation and Context

After feedback from various sites after a dynamic adjustment of the width of the left menu, I implemented this here.

How Has This Been Tested?

  • Manually tested (Chrome and Firefox)
  • Works on other browsers as well (no special CSS tweaks)

Screenshots:

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS requested review from phil-davis and pmaier1 June 7, 2020 15:44
@ChrisEdS ChrisEdS self-assigned this Jun 7, 2020
@codecov
Copy link

codecov bot commented Jun 7, 2020 •
edited
Loading

Codecov Report

Merging #37490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37490   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19336    19336           
=========================================
  Files          1277     1277           
  Lines         75535    75535           
  Branches       1331     1331           
=========================================
  Hits          48860    48860           
  Misses        26283    26283           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <ø> (ø) 19336.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d267c92...90f08e7. Read the comment docs.

@ChrisEdS ChrisEdS requested a review from micbar June 7, 2020 17:58
@ChrisEdS ChrisEdS force-pushed the menu-improvements branch 4 times, most recently from 4deffb8 to 294936b Compare June 7, 2020 21:11
pmaier1
pmaier1 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx 👍 (not a technical review :) )

@phil-davis
Copy link
Contributor

phil-davis commented Jun 8, 2020 •
edited
Loading

@ChrisEdS I am not sure why you have merged these phpstan commits into your branch. Actually in your local git clone you just do something like:

git fetch origin
git checkout master
git pull
git checkout menu-improvements
git rebase master
git push -f

And then also you still need to add a changelog.

@ChrisEdS ChrisEdS force-pushed the menu-improvements branch 2 times, most recently from 8de296a to ea35add Compare June 8, 2020 12:32
Change the behavior of the header menus
90f08e7 
Cleanup code

Add hover effect to the right menu

Use RGBA instead of HEX

Fix typo

Add changelog entry
@ChrisEdS ChrisEdS force-pushed the menu-improvements branch from ea35add to 90f08e7 Compare June 8, 2020 12:39
phil-davis
phil-davis approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with chrome and works.

@owncloud owncloud deleted a comment from update-docs bot Jun 8, 2020
@phil-davis phil-davis merged commit de488c0 into master Jun 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the menu-improvements branch June 11, 2020 13:30
@davitol davitol mentioned this pull request Jun 25, 2020
Closed
65 tasks
@ChrisEdS ChrisEdS mentioned this pull request Jul 31, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@micbar micbar Awaiting requested review from micbar

+1 more reviewer

@pmaier1 pmaier1 pmaier1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChrisEdS ChrisEdS

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChrisEdS @phil-davis @pmaier1
X Tutup