Use BackendUserIterator with uid filter for user:sync --uid#37398
Merged
Use BackendUserIterator with uid filter for user:sync --uid#37398
Conversation
mrow4a
changed the title
mrow4a
force-pushed
the
bugfix/user-sync-uid-iterator
branch
from
8a17b2b to
66f26e1
Compare
mrow4a
force-pushed
the
bugfix/user-sync-uid-iterator
branch
from
66f26e1 to
0224143
Compare
jvillafanez
approved these changes
May 18, 2020
Contributor
|
No codecov arrived. I also had this happen yesterday. Someone can decide if they want to override to merge, or if this should be rebased to try again. |
65 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit dd84405 introduced a problem that when searching for a user in LDAP backend that does not fit in LDAP Paging Size made
user:sync --uidbreak (essentially not finding it and attempting to removeHow tested?
1_aaliyah_abernathy,aaliyah_abernathyandaaliyah_abernathy_1at the beginning, searched foraaliyah_abernathy- without this fix it works, with this fix it also it works1_abagail_zieme,abagail_ziemeandabagail_zieme_1at the end, searched forabagail_zieme- without this fix it wont work, with this fix it works (fixes https://github.com/owncloud/enterprise/issues/3981)