Description

Allows read URL params of PUT request with an empty body more than once.
Missing or 0 Content-Length means that the request has an empty body and we should NOT throw LogicException while reading it.

How Has This Been Tested?

1. Create an OCS route with urlParam like this:

[
	'root' => '/cloud',
	'name' => 'Users#enableUser',
	'url' => '/users/{userId}/enable',
	'verb' => 'PUT'
],

2. Create a controller

use OCP\AppFramework\OCSController;

class UsersController extends OCSController {
/**
	 * @NoCSRFRequired
	 *
	 * @param string $userId
	 * @return Result
	 */
	public function enableUser($userId) {
		return $this->setEnabled($userId, true);
	}

2. Use it

curl -X PUT http://admin:admin@localhost/OC/ocs/v1.php/cloud/users/fatima/enable

Expected

$userId is 'fatima' in the controller

Actual

$userId is null

The log file contains

{"reqId":"08vb9aIDIHfQVAQp5ZB1","level":3,"time":"2020-05-15T09:19:24+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"PHP","method":"PUT","url":"\/OC\/ocs\/v1.php\/cloud\/users\/user1\/disable","message":"LogicException: \"put\" can only be accessed once if not application\/x-www-form-urlencoded or application\/json. at 
 \/lib\/private\/AppFramework\/Http\/Request.php#395"}

OCS routes always get format param from URL and adding one more URL param causes a logic exception

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE