Use OcsController in provisioning_api routes#37382
Closed
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
VicDeo
force-pushed
the
provisioning-routes
branch
10 times, most recently
from
739bc51 to
4ce1808
Compare
VicDeo
force-pushed
the
provisioning-routes
branch
from
2569e6a to
c9015b7
Compare
VicDeo
force-pushed
the
provisioning-routes
branch
3 times, most recently
from
641d013 to
fcbfdce
Compare
Codecov Report
@@ Coverage Diff @@
## master #37382 +/- ##
============================================
- Coverage 64.75% 64.73% -0.02%
- Complexity 19408 19423 +15
============================================
Files 1285 1287 +2
Lines 75830 75856 +26
Branches 1336 1336
============================================
+ Hits 49101 49108 +7
- Misses 26335 26354 +19
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
VicDeo
force-pushed
the
provisioning-routes
branch
3 times, most recently
from
392fbfa to
e745d95
Compare
VicDeo
force-pushed
the
provisioning-routes
branch
from
e745d95 to
6b41735
Compare
VicDeo
force-pushed
the
provisioning-routes
branch
from
6b41735 to
c958f7b
Compare
Member
|
old aka dead -> close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#12454
Motivation and Context
How Has This Been Tested?
Acceptance and unit tests
Known issues / TODO:
997but403for unauthorized users - custom security middleware neededContent-Type: application/json,Content-Type: application/x-www-form-urlencodedor non-empty request body due to https://github.com/owncloud/core/blob/7ded2889df85c6c049a90f3aff8bc8b7bcc96fb7/lib/private/AppFramework/Http/Request.php#L390-399 - blocked by Allow reading params of PUT with empty body more than once #37394e.g.
curl -X PUT http://admin:admin@/oc/ocs/v1.php/cloud/users/user1/disable -H 'Content-Type: application/json'worksbut
curl -X PUT http://admin:admin@/oc/ocs/v1.php/cloud/users/user1/disabledoes NOTTypes of changes
Checklist: