Catch setSharedWith InvalidArgumentException#37343
Closed
phil-davis wants to merge 3 commits intomasterfrom
Closed
Catch setSharedWith InvalidArgumentException#37343phil-davis wants to merge 3 commits intomasterfrom
phil-davis wants to merge 3 commits intomasterfrom
Conversation
Contributor
Author
|
@karakayasemi should we do something like this? |
Contributor
Yes, this looks good. I don't know, why these exceptions are ignored before. We can continue with this PR. Need to add an explanatory comment to |
Contributor
Author
|
@karakayasemi Please cherry-pick into your PR and add some unit tests etc. |
Contributor
Author
|
closing - this code will go into the parent PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POC on top of PR #37336
This PR demonstrates how we could catch an
InvalidArgumentExceptionthrown bysetSharedWithif someone does an API call like:So they get a 403 and error message instead of a 500 with no message.
Related Issue
#37324
How Has This Been Tested?
Needs unit tests.
Types of changes
Checklist: