@VicDeo I expect that you will need to adjust acceptance test scenario https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavProperties/setFileProperties.feature#L23 to check for the now-correct value being returned.

@phil-davis thanks. I want to check whether it fails anything else.

Please keep in mind that this table is really hugh on some installations - schema change will take forever .....

@DeepDiver1975 yes, but it is possible to add these fields in advance before upgrading the code.
I wrote the migration in a way that it does nothing when the field exists already

@phil-davis I updated the acceptance test as it parsed complex values incorrectly.

Codecov Report

Merging #37314 into master will decrease coverage by 0.00%.
The diff coverage is 67.30%.

@@             Coverage Diff              @@
##             master   #37314      +/-   ##
============================================
- Coverage     64.55%   64.54%   -0.01%     
- Complexity    19207    19216       +9     
============================================
  Files          1267     1268       +1     
  Lines         75065    75097      +32     
  Branches       1331     1331              
============================================
+ Hits          48458    48475      +17     
- Misses        26215    26230      +15     
  Partials        392      392              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38bb87...3f38112. Read the comment docs.

@pmaier1 Let us consider to include it in 10.5

Code changes look fine.
There is a deleted comment about Oracle and php 7.4. I'm not sure if we have tests with that setup or if this has been tested.

There is a deleted comment about Oracle and php 7.4. I'm not sure if we have tests with that setup or if this has been tested.

Is it related to #37312 ? and issue #37026 ? That was an intermittent problem with restoring checksums from trashbin with Oracle. (maybe not related)

Is it related to #37312 ? and issue #37026 ? That was an intermittent problem with restoring checksums from trashbin with Oracle. (maybe not related)

This is the comment https://github.com/owncloud/core/pull/37314/files#diff-d9adeff76c4cf2852e19574ce708c588L190-L192
It seems unrelated to the checksum problem mentioned

@jvillafanez

This is the comment https://github.com/owncloud/core/pull/37314/files#diff-d9adeff76c4cf2852e19574ce708c588L190-L192
It seems unrelated to the checksum problem mentioned

This PR fixes exactly that FixMe: a webdav property constructed using a class Complex is serialized properly now. Not just for Oracle, but everywhere.

// FIXME: PHP 7.4 handles object serialization differently so we store 'Object' here
// to keep old (wrong) behavior and fix Oracle failure

this means: All DBMS were storing Object instead of the correct value. In addition Oracle was exploding, that's why I added that fixme - to store Object for all DBMS.
After this PR is merged there is no need in the fixup - the value is stored and restored properly.