X Tutup
Skip to content

Bump icewind/streams from 0.7.1 to 0.7.2 in /apps/files_external/3rdparty#37249

Merged
phil-davis merged 3 commits intomasterfrom
dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2
May 11, 2020
Merged

Bump icewind/streams from 0.7.1 to 0.7.2 in /apps/files_external/3rdparty#37249
phil-davis merged 3 commits intomasterfrom
dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 13, 2020 •
edited
Loading

Bumps icewind/streams from 0.7.1 to 0.7.2.

Release notes

Sourced from icewind/streams's releases.

0.7.2

  • Fix composer psr-4 warnings
Commits
  • 77d750c split dummy classes in tests into their own file
  • f1d138e fix file name casing
  • 8b563b4 move tests namespace to autoload-dev
  • 85b84ed test against 7.4
  • 6c91d3e add stream wrapper to calculate hash on write
  • 59d8a6a Merge pull request #11 from rullzer/add_hash_wrapper
  • ac08c36 fixup! Added a simple hash wrapper
  • 9d525cc fixup! Fix new loader
  • 8a1095e fixup! Fix new loader
  • afe2b57 Only load protocol if not speified
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies php Pull requests that update Php code labels Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #37249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37249   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity    19220    19220           
=========================================
  Files          1268     1268           
  Lines         75105    75105           
  Branches       1331     1331           
=========================================
  Hits          48496    48496           
  Misses        26217    26217           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.72% <ø> (ø) 19220.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35ed57...447d1e7. Read the comment docs.

@phil-davis
Copy link
Contributor

phil-davis commented Apr 14, 2020

See #37186 - I added the code for this icewind/streams version bump to that PR.
Note: it needs more than just the composer.json composer.lock changes that the bot suggests. The actual code changes are committed to the core repo also, and so those need to be applied.

@phil-davis phil-davis self-assigned this Apr 14, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2 branch 2 times, most recently from a273427 to 192685f Compare April 17, 2020 14:22
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2 branch from 192685f to 3aaaa84 Compare May 11, 2020 10:32
@phil-davis
Copy link
Contributor

phil-davis commented May 11, 2020

@dependabot rebase

@dependabot-preview
Bump icewind/streams in /apps/files_external/3rdparty
f943206 
Bumps [icewind/streams](https://github.com/icewind1991/Streams) from 0.7.1 to 0.7.2.
- [Release notes](https://github.com/icewind1991/Streams/releases)
- [Commits](icewind1991/Streams@v0.7.1...v0.7.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2 branch from 3aaaa84 to f943206 Compare May 11, 2020 12:08
@phil-davis
Copy link
Contributor

phil-davis commented May 11, 2020

It might be easier to get this tested and merged first. Then we can think about icewind/smb separately.

The 2nd commit is the actual code for icewind/streams 0.7.2 which I got by:

git checkout dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2
cd apps/files_external/3rdparty
composer install
git add -A
git commit -S -m "Commit apps/files_external/3rdparty/icewind/streams-0.7.2 code"

@phil-davis
Copy link
Contributor

phil-davis commented May 11, 2020

Note: this was updated in the root of the core repo in PR #37253

@owncloud owncloud deleted a comment from update-docs bot May 11, 2020
@phil-davis
Copy link
Contributor

phil-davis commented May 11, 2020

IMO this can/should be updated to match what is in the root composer.lock of this repo.
Reviewers, let me know if I have missed something, or done the wrong steps... to get the needed files.

VicDeo
VicDeo approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any specific steps to update this library.
Steps are looking correct to me

@phil-davis phil-davis merged commit 3385609 into master May 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/apps/files_external/3rdparty/icewind/streams-0.7.2 branch May 11, 2020 14:38
This was referenced May 12, 2020
Closed
Merged
@davitol davitol mentioned this pull request Jun 25, 2020
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VicDeo VicDeo VicDeo approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

@micbar micbar Awaiting requested review from micbar

@karakayasemi karakayasemi Awaiting requested review from karakayasemi

Assignees

@phil-davis phil-davis

Labels

dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @VicDeo
X Tutup