X Tutup
Skip to content

RepairUnmergedShares: sum up users across all backends#37246

Merged
VicDeo merged 1 commit intomasterfrom
bugfix/37241
Apr 14, 2020
Merged

RepairUnmergedShares: sum up users across all backends#37246
VicDeo merged 1 commit intomasterfrom
bugfix/37241

Conversation

@VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 13, 2020 •
edited
Loading

Description

$this->userManager->countUsers() returns an array backend => count so wee need to sum it up to get all users count.

Related Issue

Motivation and Context

Broken upgrade from 9.1

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo self-assigned this Apr 13, 2020
@VicDeo VicDeo changed the title Count all users for all backends Send user count as integer Apr 13, 2020
@VicDeo VicDeo changed the title Send user count as integer RepairUnmergedShares: sum up users across all backends Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020 •
edited
Loading

Codecov Report

Merging #37246 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37246   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
- Complexity    19148    19150    +2     
=========================================
  Files          1267     1267           
  Lines         74895    74901    +6     
  Branches       1331     1331           
=========================================
+ Hits          48626    48632    +6     
  Misses        25877    25877           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.13% <100.00%> (+<0.01%) 19150.00 <2.00> (+2.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair/RepairUnmergedShares.php 35.15% <100.00%> (+3.18%) 41.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fa496...0d359a2. Read the comment docs.

@VicDeo VicDeo added this to the development milestone Apr 14, 2020
@VicDeo VicDeo requested review from DeepDiver1975 and micbar April 14, 2020 09:10
@owncloud owncloud deleted a comment from update-docs bot Apr 14, 2020
@VicDeo VicDeo merged commit 76900ab into master Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/37241 branch April 14, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

1 more reviewer

@micbar micbar micbar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VicDeo VicDeo

Labels

3 - To Review

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

Upgrade from 9.1.0 to 10.4

2 participants

@VicDeo @micbar
X Tutup