X Tutup
Skip to content

Update nikic/php-parser (4.3.0 => 4.4.0)#37237

Merged
individual-it merged 1 commit intomasterfrom
bump-php-parser-4.4.0
Apr 13, 2020
Merged

Update nikic/php-parser (4.3.0 => 4.4.0)#37237
individual-it merged 1 commit intomasterfrom
bump-php-parser-4.4.0

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Apr 11, 2020

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating nikic/php-parser (v4.3.0 => v4.4.0): Loading from cache

https://github.com/nikic/PHP-Parser/releases/tag/v4.4.0

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis added 3 - To Review dependencies php Pull requests that update Php code labels Apr 11, 2020
@phil-davis phil-davis self-assigned this Apr 11, 2020
@phil-davis phil-davis mentioned this pull request Apr 11, 2020
Merged
11 tasks
@codecov
Copy link

codecov bot commented Apr 11, 2020 •
edited
Loading

Codecov Report

Merging #37237 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37237   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
  Complexity    19148    19148           
=========================================
  Files          1267     1267           
  Lines         74895    74895           
  Branches       1331     1331           
=========================================
  Hits          48626    48626           
  Misses        25877    25877           
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.12% <ø> (ø) 19148.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd7d4a...cb28395. Read the comment docs.

@phil-davis phil-davis mentioned this pull request Apr 12, 2020
Closed
@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 12, 2020 •
edited
Loading

Anybody please approve this so it can be merged. That will likely help owncloud/search_elastic#165

And see #37243 - phpstan CI currently fails in master and this fix is needed.

This was referenced Apr 12, 2020
Merged
Merged
@individual-it individual-it merged commit 33c8b77 into master Apr 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-php-parser-4.4.0 branch April 13, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes

@micbar micbar Awaiting requested review from micbar

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

@VicDeo VicDeo Awaiting requested review from VicDeo

Assignees

@phil-davis phil-davis

Labels

3 - To Review dependencies php Pull requests that update Php code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phil-davis @individual-it
X Tutup