Description

Pending federated shares have no related filesystem item so extending them via View::getFileInfo leads to errors in the log file

Related Issue

• Fixes apps/files_sharing/api/v1/remote_shares/{id} returns empty content for not accepted shares #34636

Motivation and Context

Share info requested by id via OCS was empty for pending federated shares.

How Has This Been Tested?

1. from server1 share a folder to server2
2. on server2 do not accept the share
3. on server2 find the share-id curl -u admin:admin http://localhost/owncloud-core/ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending
4. try to get information about that share curl -u admin:admin http://localhost/owncloud-core/ocs/v1.php/apps/files_sharing/api/v1/remote_shares/22 -v

Expected behaviour

information of the share shown

Actual behaviour

HTTP code 200 but empty content

{"reqId":"jeeKxCEMNmITSnccyKE4",
"level":3,
"time":"2020-04-06T10:12:08+00:00",
"remoteAddr":"127.0.0.1",
"user":"admin",
"app":"PHP",
"method":"GET",
"url":"\/ocs\/v1.php\/apps\/files_sharing\/api\/v1\/remote_shares\/32",
"message":"Error: Call to a member function getMimetype() on boolean at \/apps\/files_sharing\/lib\/Controller\/RemoteOcsController.php#213"}

in the log file

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE